search

src-d / kmcuda

Large scale K-means and K-nn implementation on NVIDIA GPU / CUDA
Other
806 stars 145 forks source link

Kmcuda for windows bugfixes #62

Open pavlexander opened 5 years ago

pavlexander commented 5 years ago

The changes that were suggested in this pull request are meant to make kmcuda to be compatible on Windows from within VisualStudio 2017 environment. By default - the build fails due to several errors.

See issue #50

Signed-off-by: Aleksandrs Pavlenko pavnexus@gmail.com

pavlexander commented 5 years ago

My commits were lacking "Signed-off-by" so I added the signature to pull request itself. Unfortunately I couldn't find a way of changing existing comments for commits :) Let me know if this is a no-go and I will re-fork the project and re-apply all the fixes accordingly to DCO with correct comments.

vmarkovtsev commented 5 years ago

@pavlexander Can you please squash all your commits together - this is preferred in this case.

pavlexander commented 5 years ago

I must have done something wrong.. Another commit was created automatically, called "Merge branch.." which I was not planning to create! Trying to figure out what went wrong. Maybe I will create another pull request..

pavlexander commented 5 years ago

For some reason when I create a squashed commit, then I am forced to pull previous 22 commits. When that happens, then I am also forced to create an empty "merge" commit, which seems to be failing DCO for some reason, even though it has a sign-off..

pavlexander commented 5 years ago

Can anyone explain why merge commit from local to remote causes DCO to fail? Even if it has a sign-off?

Sorry, I will be creating a new fork and a new pull request.. Sorry for inconvenience. Still learning git. :) Seems like it's the best option in this situation.

vmarkovtsev commented 5 years ago

Maybe this will help: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md

ComicAddict commented 2 months ago

Are there any plans to merge this PR?