src-d / lookout-gometalint-analyzer

GNU Affero General Public License v3.0
1 stars 5 forks source link

Improve message from dup analyzer #7

Closed smacker closed 5 years ago

smacker commented 6 years ago

Example of comment from dupl analyzer: https://github.com/src-d/lookout/pull/224#discussion_r215352817

duplicate of /tmp/gometalint178171015/provider.github.poster_test.go:141-164 (dupl)

Todo:

  1. remove prefix of temporary directory (most probably the easiest way is to preprocess all output removing tmp dir string. It's quite unique)
  2. change artificialSep so it wouldn't be displayed as markdown. Or just create directories instead. Or change separator back to "/" before posting.
bzz commented 6 years ago

Thank you for filing this!

Indeed:

The expected behaviour is - file path should be reconstructed back to original one, before reporting

smacker commented 6 years ago

we run all file-level analysis together in a single run, so I belive it needs to have all files in a single directory to do so

what is the problem with gometalinter.v2 <tmp-path>/...?