search

src-d / lookout-sdk

SDK for lookout analyzers
Apache License 2.0
4 stars 11 forks source link

fix(python example): Close channel to data server #46

Closed smacker closed 5 years ago

smacker commented 5 years ago

Currently open channels just hang there.

Ref: https://github.com/grpc/grpc/pull/15725

Signed-off-by: Maxim Sukharev max@smacker.ru

smacker commented 5 years ago

with statement is more pythonic. It should be always used if possible. Sorry, no link for it but if you check documentation for os modules for example, you will see that all examples use with.

dpordomingo commented 5 years ago

Yes, I saw it in the good reference you added in the PR desc, so lgtm :dagger: thanks for the double clarification :tada:

dpordomingo commented 5 years ago

example analyzers are now under examples dir; sorry :wink: I think once you solve the conflict @carlosms will agree if you merge the PR :crossed_swords:

smacker commented 5 years ago

Looks like it was already fixed by another PR.