Mention caveat and fix for connections to data-server in golang

src-d / lookout-sdk

SDK for lookout analyzers

Apache License 2.0

4 stars 11 forks source link

Mention caveat and fix for connections to data-server in golang #66

Closed smacker closed 5 years ago

smacker commented 5 years ago

Ref: https://github.com/src-d/lookout-sdk/issues/64

carlosms commented 5 years ago

Is this something we should add to the go example analyzer?

smacker commented 5 years ago

Example analyzer doesn't keep an open connection to data server but opens a new one for each event.

smacker commented 5 years ago

All of them use a new connection for each request as far as I remember. We don't have any "production-ready" go analyzer which would keep an open connection.