search

src-d / lookout-sdk

SDK for lookout analyzers
Apache License 2.0
4 stars 11 forks source link

Modify proto with ChangeRequest.TwoDotsMode #76

Open dpordomingo opened 5 years ago

dpordomingo commented 5 years ago

blocks https://github.com/src-d/lookout/pull/530

In order to show the same changes than appear in Changes tab from GitHub PRs, the standard behavior for DataService.GetChanges is returning the changes as if doing git diff base...head (what works as git diff $(git merge-base base head) head)

If the analyzer wants all changes between base and head, (as done by git diff base..head) it must send TwoDotsMode as true in the ChangesRequest.

dpordomingo commented 5 years ago

It would be great if we could release this before merging src-d/lookout#530 to see Travis pass :dancer: I know that if we merge this before the other, the analyzers will still having the same bug that previously, but since it's its current behavior... wdyt?

carlosms commented 5 years ago

Sorry, I didn't mean to merge https://github.com/src-d/lookout/pull/530 before this one. What I meant is to: