No push notification for local PRs

[vmarkovtsev]

If you edit a file using GitHub UI and then create a PR to the same repository from a new branch, Lookout notifies only a new Review event. Although a new branch appears, there is no Push event.

[se7entyse7en]

@carlosms what to we want to do for this?

[carlosms]

Let's see first if we can reproduce it, for master or any other branch.

[smacker]

I used as example this PR: https://github.com/bblfsh/uast-viewer/pull/89 it is created from a local branch greenkeeper/react-styleguidist-9.0.0

In the events endpoint I see such events:

• CreateEvent:

  id  "9101240193"
  type    "CreateEvent"
  actor   {…}
  repo    {…}
  payload 
  ref "greenkeeper/react-styleguidist-9.0.0"
  ref_type    "branch"
  master_branch   "master"
  description null
  pusher_type "user"
  public  true
  created_at  "2019-02-20T10:35:08Z"
  org {…}

• PullRequestEvent:

id	"9101240662"
type	"PullRequestEvent"
actor	{…}
repo	{…}
payload
action	"opened"
number	89
pull_request	{…}
public	true
created_at	"2019-02-20T10:35:11Z"
org	{…}

There is no PushEvent indeed. Maybe we should handle CreateEvent as PushEvent when `ref_type= branch`. Though it doesn't have enough information. So we will have to call some additional endpoints.

[carlosms]

@marnovo do we want to create a push notification in this case?