src-d / ml-core

source{d} MLonCode foundation - core algorithms and models.
Other
14 stars 16 forks source link

Add bilstm tokenizer to tokenparser #25

Closed glimow closed 5 years ago

glimow commented 5 years ago

Signed-off-by: tristan kalos tristan.kalos@live.fr

vmarkovtsev commented 5 years ago

Hey @glimow can you please finish this PR while you still have time

glimow commented 5 years ago

@vmarkovtsev sure. I'll try to close it tomorrow.

glimow commented 5 years ago

@vmarkovtsev tests should pass, PTAL

zurk commented 5 years ago

hey, @glimow, CI failed. Also, can you rebase, so we do not have a merge commit here?

Tip: to make style check pass add

pydocstyle==3.0.0 # remove when https://gitlab.com/pycqa/flake8-docstrings/issues/36 is solved

to requirements-lint.txt

glimow commented 5 years ago

@vmarkovtsev I updated to match comments :)