search

src-d / ml-core

source{d} MLonCode foundation - core algorithms and models.
Other
14 stars 16 forks source link

Ci #3

Closed Guillemdb closed 5 years ago

Guillemdb commented 5 years ago

Making PR according to @vmarkovtsev suggestions.

Add CI. The repo is empty so it passes. CI should additionally test packaging btw.

I don't know how to test packaging. Can you send me a tutorial or something? I was planning to do it after the first PR was merged.

zurk commented 5 years ago

.ci directory should be added to .gitignore Makefile pulls it automatically.

zurk commented 5 years ago

can you squash it into one commit to avoid having '`ci' in git history?

Guillemdb commented 5 years ago

@vmarkovtsev As there is no code yet the CI won't pass. I can choose to screw up the CI files to make the CI checks pass, or I can wait for the next PR to include the code.

And If I merge the code from the refactor branch here, the tests will fail because they need fixing.

Should I also add a commit witht the tests fixing? (I am asking this because you told me to make no changes to the code functionality)

zurk commented 5 years ago

you can add @unittest.skip decorator for now. I think it is fine

zurk commented 5 years ago

@Guillemdb CI is failed. Please request a review when you fix it.

Guillemdb commented 5 years ago

@zurk I have no idea why the build fails. It is obviously missing some files, but I don't know what are the files that need to be there so the CI passes.

PR#4 is working like a charm. Is really necessary that I spend more time trying to fix something that works there, and then rebasing everything?

EDIT: cd $(pip show sourced.ml.core|grep Location|cut -d' ' -f2)/sourced/ml/core This is the line which is making the travis build fail. With the whole project in the folder it works, but I don't know which are the required files and why.

zurk commented 5 years ago

Vadim's feedback is fulfilled so I am merging