search

src-d / ml-core

source{d} MLonCode foundation - core algorithms and models.
Other
14 stars 16 forks source link

Refactor #4

Closed Guillemdb closed 5 years ago

Guillemdb commented 5 years ago

PR is based on https://github.com/src-d/ml-core/pull/3

This PR will contain the changes suggested by @vmarkovtsev in https://github.com/src-d/ml-core/pull/1

  1. Add the old code. Pass CI.
Guillemdb commented 5 years ago

Konst made some changes to pass the tests:

Also, the version of modelforge used in the requirements is updated to modelforge==0.12.1

vmarkovtsev commented 5 years ago

@Guillemdb Please rebase this on the latest changes in the other 2 PRs

zurk commented 5 years ago

ok, I updated comment that PR is based on https://github.com/src-d/ml-core/pull/3. Let's deal with it first.

zurk commented 5 years ago

@Guillemdb please rebase and solve the conflict