src-d / modelforge

Python library to share machine learning models easily and reliably.
Apache License 2.0
18 stars 13 forks source link

Add Git based Index #25

Closed r0mainK closed 6 years ago

r0mainK commented 6 years ago

Pretty big PR implementing the Git based index:

Breakdown of the changes:

vmarkovtsev commented 6 years ago

OK, this is a bit too much for me :)

Please split. I would suggest:

  1. Readme and docs are the last
  2. Templates and requirements are the first
  3. storage_backend.py changes separate
  4. The rest shall be splitted too - see what's the best way yourself

Amazing work btw, can't wait to have it merged.

r0mainK commented 6 years ago

Aha no problem, thks ^^ okay then I'll split in something like 5 or 6 PRs, then close this

marnovo commented 6 years ago

@r0mainK @vmarkovtsev what issue is this related to?

vmarkovtsev commented 6 years ago

@marnovo https://github.com/src-d/backlog/issues/1205

r0mainK commented 6 years ago

@marnovo this issue: https://github.com/src-d/backlog/issues/1205

basically having the index of the registry on the backend was not great so now it's gonna be exclusively on github, e.g. https://github.com/src-d/models , and itll be updated with modelforge cmds.

vmarkovtsev commented 6 years ago

Closing - it was splitted.

vmarkovtsev commented 6 years ago

LOL

r0mainK commented 6 years ago

aha

marnovo commented 6 years ago

Thanks! Please let's always try to reference things around so people have more context of why/what is going one.

Idea for the future: intelligent PR splitter, to split large PRs into more manageable ones for review. ;)