src-d / modelforge

Python library to share machine learning models easily and reliably.
Apache License 2.0
18 stars 13 forks source link

Add git based index [part 2] #27

Closed r0mainK closed 6 years ago

r0mainK commented 6 years ago

The class representing the index. We use dulwich to manage a cached repo that serves as a local copy of the git repo -> dulwich implements clone/pull/commit/push etc.

At init uses regex to check the given remote_repo, username and password args have a correct format, if either is missing there is no auth in the url. Also initializes commit message and calls fetch index.

r0mainK commented 6 years ago

Ok so there were some subtle things about dulwich i did not take into account, so gonna rewrite the init to handle all protocols/domains names, and will let it do the rest, e.g. check repo exists and credentials are correct

vmarkovtsev commented 6 years ago

Cool. Yes, this is the best we can do.

r0mainK commented 6 years ago

@vmarkovtsev fixed tests we can merge this