search

src-d / modelforge

Python library to share machine learning models easily and reliably.
Apache License 2.0
18 stars 13 forks source link

Update backend [part 4] #29

Closed r0mainK closed 6 years ago

r0mainK commented 6 years ago

Take out unused methods in backend relating to the index, add initialize_backend method, create helper function in gcs_backend to avoid redundancy

vmarkovtsev commented 6 years ago

@r0mainK There are merge conflicts

r0mainK commented 6 years ago

@vmarkovtsev solved them, ready for review when you get the time

r0mainK commented 6 years ago

Added catches about everywhere, and moved the message to the logger in most cases. I put two TODO for when dulwich implements a porcelain error. Gonna add some test now, to get coverage a bit higher. But yeah ready for more review or merge after that. I'm also gonna reorder the methods and functions so they are more coherent.