[MINOR] Typos, renaming, other stuff

src-d / modelforge

Python library to share machine learning models easily and reliably.

Apache License 2.0

18 stars 13 forks source link

[MINOR] Typos, renaming, other stuff #32

Closed r0mainK closed 6 years ago

r0mainK commented 6 years ago

Before I forget to address the last somments on the PR, here it is.

I'm not sure it is best to add further logs before the return 1 in registry functions, when there is no log at that point it is because a log has already been prompted in the function where the error happened. Unless you want to add genereic log messages like "failed while uploading the index", etc.

vmarkovtsev commented 6 years ago

Yeah, the point is to always have a log message once smth goes wrong, in either the calling side or the API side. I am ok with both but just want to catch the errors with the finest precision.

r0mainK commented 6 years ago

Yes, I see. After looking at it a bit more, from what I see there the try/except blocks fall into one of these categories:

error specific to the backend used, logs should be inside the backend
ValueError that is future PorcelainError -> to be modified later
ValueError in git index: it's the only kind of error, and we always log a specific message where the failure happened