Closed erizocosmico closed 7 years ago
We can error if we see type int
that user should change it to int32
or int64
.
This was fixed, right?
Yes, but since we are using services
it is not closed automagically.
What are you referring to with services
?
services
branch.
I see.
I'm not familiar with the details, so this suggestion might be off base, but have you considered making that branch the default branch of this repository? If you're using it that way.
Then, when a PR merged into services
branch says "fixes" some issue, it will get closed by github.
It would affect go get
, so perhaps you don't want to do it.
We were using services
branch as a "development" branch until all the pending issues and the gRPC services implementation were finished. It should be finished today or tomorrow and we'll merge it into master.
Problem
There is no
int
in protobuf, onlyint32
andint64
. Then, when we generate the .proto file we have to choose between one of them. Right now, the choice isint32
.Problem is, when doing the gogoproto step, it takes into account the proto file, and not the Go source code, and thus what it thinks is that the type is an
int32
instead ofint
.Steps to reproduce:
//proteus:generate type Foo struct { A int }