search

src-d / proteus

Generate .proto files from Go source code.
https://blog.sourced.tech/post/proteus/
MIT License
735 stars 70 forks source link

[FIX] Regenerate code if needed #73

Closed Serabe closed 7 years ago

Serabe commented 7 years ago

If the user provides a Server constructor or struct, we don't generate it.

The problem is that, when running proteus twice, it would detect the previously autogenerated method as the one supplied by the user, not generating it again. When the file gets overwritten, the struct would be lost.

This fixes that problem and the way to test it is a bit meh: example/Makefile calls proteus twice in a row.

codecov[bot] commented 7 years ago

Codecov Report

Merging #73 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   91.12%   91.17%   +0.05%     
==========================================
  Files          13       13              
  Lines        1374     1382       +8     
==========================================
+ Hits         1252     1260       +8     
  Misses        103      103              
  Partials       19       19
Impacted Files Coverage Δ
rpc/rpc.go 94.39% <100%> (+0.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 845d349...6fce56e. Read the comment docs.