src-d / proteus

Generate .proto files from Go source code.
https://blog.sourced.tech/post/proteus/
MIT License
735 stars 70 forks source link

Make Scope work with Proteus #76

Closed Serabe closed 6 years ago

Serabe commented 7 years ago

Repo: https://github.com/kinvolk/scope/tree/alban/proteus

The problem is related to map[string]SomeStruct, given the value type is not nullable and protobuf expects so. I'm investigating an option for gogo/protobuf to allow a value type to be nullable in a map.

Current problems:

alban commented 7 years ago

@Serabe Thanks for looking at this!

Upstream repo: https://github.com/weaveworks/scope/ Scope issue about trying Proteus: https://github.com/weaveworks/scope/issues/2433

/cc @2opremio @schu @iaguis

Serabe commented 7 years ago

Updated text and removed the EPIC label since they are all the same problem.

Serabe commented 7 years ago

@alban I submitted this morning a PR to alban/proteus https://github.com/kinvolk/scope/pull/5

Basically, I fixed all the problems I found and made a new release. Then, I did a make clean to make sure everything was removed properly and tried again. I also added some files from gogo/protobuf that are really needed (those can be found in the PR).

Thank you!