src-d / regression-core

Common functionality for regression testers
Apache License 2.0
0 stars 8 forks source link

`latest` does not download the latest release. Instead it downloads the most recent #22

Open carlosms opened 5 years ago

carlosms commented 5 years ago

For example, right now for gitbase the latest release is v0.23.1, but for the argument latest regression-gitbase will download the most recent tag, v0.24.0-rc3, which is a pre-release.

The fix would be to use GetLatestRelease instead of ListReleases in releases.go. I didn't submit a PR directly because I'm not sure if this would break something somewhere... let me know if this change makes sense and I'll submit one.

ajnavarro commented 5 years ago

Maybe in this context, if you choose latest version, you want the newer version, even if it is an RC. On Jenkins we are not using this flag, we are generating reports from master every day with new commits.