search

src-d / sourced-ce

source{d} Community Edition (CE)
https://docs.sourced.tech/community-edition
GNU General Public License v3.0
188 stars 51 forks source link

Consider removing `completion` command on Windows #169

Closed se7entyse7en closed 5 years ago

se7entyse7en commented 5 years ago

While investigating #168.

The completion command is specific to bash. Given that we've been testing sourced-ce with powershell as we used to do for engine, it makes sense to remove it for Windows.

dpordomingo commented 5 years ago

I think we should move this to https://github.com/src-d/go-cli wdyt @smola ?

carlosms commented 5 years ago

Reopening because https://github.com/src-d/go-cli/pull/20 does not fix this one until we update the version in go.mod

dpordomingo commented 5 years ago

Since we're not using cli.New, but cli.NewNoDefaults, and then we're manually adding the cli.CompletionCommand, I think that the fix provided by src-d/go-cli#20 won't solve our problem.

https://github.com/src-d/go-cli/pull/21 should solve our problem.