search

src-d / sourced-ce

source{d} Community Edition (CE)
https://docs.sourced.tech/community-edition
GNU General Public License v3.0
185 stars 52 forks source link

Update to go-1.13 #238

Closed carlosms closed 5 years ago

carlosms commented 5 years ago

Go 1.13 is out, according to our conventions we should update.

dpordomingo commented 5 years ago

Do we want to use go1.13 error wrapping instead of current go-error? Should we confirm it company-wide?

carlosms commented 5 years ago

I would say yes, but it's something we can do later. Maybe we can open a new issue to src-d/guide to discuss it (as the convention is documented here https://github.com/src-d/guide/blob/master/engineering/conventions/go.md#error-handling)

dpordomingo commented 5 years ago

I would say yes, but it's something we can do later. Maybe we can open a new issue to src-d/guide to discuss it (as the convention is documented here https://github.com/src-d/guide/blob/master/engineering/conventions/go.md#error-handling)

Good idea. Issue opened here https://github.com/src-d/guide/issues/383