src-d / sourced-ce

source{d} Community Edition (CE)
https://docs.sourced.tech/community-edition
GNU General Public License v3.0
188 stars 51 forks source link

Handle errors when couldn't download config or compose #247

Closed dpordomingo closed 5 years ago

dpordomingo commented 5 years ago

fix #245 motivated by https://github.com/src-d/sourced-ce/issues/241

If the user initializes or tries to download a config without access to the internet, the error is a bit cryptic.

This PR adds clearer error messages in such situations and also points to some docs explaining why is that assets needed.


When there is no local docker-compose installation, and it could not be downloaded:

When trying to download and activate a new docker-compose.yml config, but the process failed:

disclaimer

This PR does not explain how to run sourced offline, which could be done separatelly if needed.


smacker commented 5 years ago

My 5 cents. I agree with Carlos to put instruction on how to run it without the Internet into FAQ for the same reasons he explained above. Plus people tend to skip reading the documentation if there is too much text (I'm a good example of this) so keeping only what is really important increases chances that it will be actually read.

dpordomingo commented 5 years ago

Thanks for your deep review. I rebased on top of the current master, and apply the changes you suggested:

dpordomingo commented 5 years ago

Inline suggestions applied, thanks @carlosms ! @se7entyse7en your suggestions about removing defer were addressed following the conversation I had with @smacker on last Friday. Does it suit you?