search

src-d / sourced-ui

source{d} UI
https://sourced.tech
Apache License 2.0
7 stars 15 forks source link

When running with https favorite status is still requested with http #278

Closed se7entyse7en closed 4 years ago

se7entyse7en commented 5 years ago

For a demo environment running with https, when opening a dashboard the request for favorite status is done on http causing an error, and shows banner 'There was an issue fetching the favorite status of this dashboard.'

se7entyse7en commented 5 years ago

For demos this has been fixed by removing the catch of the error.

smacker commented 5 years ago

The proper fix is included in v0.34.1: https://github.com/apache/incubator-superset/pull/8013 We can backport it or just wait a bit.

se7entyse7en commented 5 years ago

Great that has been fixed upstream 👍

se7entyse7en commented 5 years ago

I'd backport it as it is a very isolated thing and also would remove us a step when setting up demos.

smacker commented 4 years ago

There are enough votes for releasing 0.34.1rc2 as 0.34.1 already from Superset team. 72 hours voting process by Apache Incubator started 2 days ago. https://lists.apache.org/thread.html/e60f080ebdda26896214f7d3d5be1ccadfab95d48fbe813252762879@%3Cdev.superset.apache.org%3E

it makes sense to wait and update srcd-ui to 0.34.1.

se7entyse7en commented 4 years ago

Thanks for the link! Yes then, let's wait 👍

smacker commented 4 years ago

released: https://github.com/apache/incubator-superset/releases/tag/0.34.1