search

src-d / sourced-ui

source{d} UI
https://sourced.tech
Apache License 2.0
7 stars 15 forks source link

Update ids in json_metadata on import #288

Closed smacker closed 4 years ago

smacker commented 5 years ago

Currently import fixes ids for position_json but not json_metadata. As the results default_filters for example are broken.

se7entyse7en commented 5 years ago

Are default_filters those applied by the filter widgets in the dashboard? And when you refer to the ids fixing on position_json, is this something that was done on our side only or included upstream? Do you have a link to the related PR/issue?

smacker commented 5 years ago

And when you refer to the ids fixing on position_json, is this something that was done on our side only or included upstream?

it was always in upstream: https://github.com/src-d/sourced-ui/blob/master/superset/superset/models/core.py#L550

Are default_filters those applied by the filter widgets in the dashboard?

those filters applied to the filter widget and to all charts in the dashboard. (unless they are in filter_immune_slices or filter_immune_slice_fields which we also don't update but should) Ref: http://superset.apache.org/faq.html#how-to-add-dynamic-filters-to-a-dashboard

se7entyse7en commented 5 years ago

thanks a lot!