search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Optimize style-analyzer tests #671

Closed zurk closed 5 years ago

zurk commented 5 years ago

Test for noisy report mostly.

zurk commented 5 years ago

@vmarkovtsev do you want to merge style and test checks back? It also improves our Travis speed by 3-5 mins.

zurk commented 5 years ago

:muscle: image

zurk commented 5 years ago

It was accidentally closed.

zurk commented 5 years ago

Long tests check: https://travis-ci.org/zurk/style-analyzer/builds/503054071 Passed: 20mins only.

warenlg commented 5 years ago

You could also decrease n_iter in the default test config to win even more time, no ?

zurk commented 5 years ago

Yes, it is true, but it is already 6. And actually we have 10 evaluations in random points, so setting less than 10 is the same.

vmarkovtsev commented 5 years ago

Which style and test checks? 🤔

zurk commented 5 years ago

We have two stages in Travis. The first one in style check (flake8) the second one is testing. One goes after another sequentially. As soon as we have more slots in Travis we can do them in parallel as before to speed up Travis running time from ~19 mins to ~15 mins.

vmarkovtsev commented 5 years ago

Now I see what you mean, thanks. It saved much resources in the past, so I don't feel that we should revert this... It has an extra nice side effect that you have a fair chance to stop the Travis build before it occupies many slots.

zurk commented 5 years ago

Good point. :+1: