Move all typos analyzer's parameters to a single config

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews

GNU Affero General Public License v3.0

32 stars 21 forks source link

Move all typos analyzer's parameters to a single config #685

Closed irinakhismatullina closed 5 years ago

irinakhismatullina commented 5 years ago

Create single config for IdTyposAnalyzer and TyposCorrector models with all default parameters for training and analyzing.

EgorBu commented 5 years ago

Even more - some parameters should be shared among several analyzers - Format/Typos/etc. For example parameters for filter_files:

"line_length_limit": 500,
"lower_bound_instances": 500,
"overall_size_limit": 5 << 20

zurk commented 5 years ago

👍 for the issue

However, let's not merge shared parameters for now, because different analyzers will possibly have different default values.

EgorBu commented 5 years ago

it's not implemented yet, let's discuss it at ML sync. TBH I think some common configuration could be even moved to lookout/core (as config for filter_files I mentioned above)

irinakhismatullina commented 5 years ago

Merged in #718.