search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Fix typos analyzer tests #688

Closed irinakhismatullina closed 5 years ago

irinakhismatullina commented 5 years ago

Related to #686.

irinakhismatullina commented 5 years ago

@EgorBu PTAL, analyzer tests now seem to have everything to pass.

vmarkovtsev commented 5 years ago

@irinakhismatullina What's up with this PR?

irinakhismatullina commented 5 years ago

@vmarkovtsev I will use it for fixing analyzer tests, hope to do it today.

vmarkovtsev commented 5 years ago

@irinakhismatullina Any update here?

irinakhismatullina commented 5 years ago

Waiting for @EgorBu to take a look, i checked what i could, can't understand what's the problem without running the analyzer myself.

irinakhismatullina commented 5 years ago

Now it's ready

EgorBu commented 5 years ago

LGTM in general. A couple of minors improvements possible

irinakhismatullina commented 5 years ago

@vmarkovtsev @EgorBu Somehow while using keyword arguments in analyzer.analyze() this strange error arises https://travis-ci.com/src-d/style-analyzer/jobs/187395746#L3334. Without keywords here everything's fine. Probably this is a wrong behavior and indicates some bugs in other places?

vmarkovtsev commented 5 years ago

@irinakhismatullina wrapped_handle_rpc_errors has been recently added by @zurk Konst should quickly find the reason.

zurk commented 5 years ago

let me see

zurk commented 5 years ago

A decorator is not mine, I think @vmarkovtsev is the original author. It is just not created to be used with named arguments. I can address it, but let's merge this code as is to not wait.

vmarkovtsev commented 5 years ago

Indeed, I confused it with bytes to unicode decorators, sorry.

vmarkovtsev commented 5 years ago

OK, now I start to remember. LEt me figure this out myself later today.

zurk commented 5 years ago

Sorry, @vmarkovtsev, too late :) https://github.com/src-d/lookout-sdk-ml/pull/81

vmarkovtsev commented 5 years ago

@EgorBu +1?

irinakhismatullina commented 5 years ago

@vmarkovtsev It's still a problem https://travis-ci.com/src-d/style-analyzer/jobs/187821986#L3349

EgorBu commented 5 years ago

LGTM

vmarkovtsev commented 5 years ago

@irinakhismatullina Of course it is, I just want Egor's formal approval here.

vmarkovtsev commented 5 years ago

@irinakhismatullina Can you please rebase