search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Use javascript-driver v2.7.0 #692

Closed zurk closed 5 years ago

zurk commented 5 years ago

Closes https://github.com/src-d/style-analyzer/issues/666 It is a draft PR.

Plan: Wait for driver v2.7.0 release, test it and finish PR.

vmarkovtsev commented 5 years ago

@zurk So 2.7.0 has been released. Any luck now?

zurk commented 5 years ago

Ongoing...

zurk commented 5 years ago

Ready for review.

zurk commented 5 years ago

Note that quality was changed in tests because I did not manage to get exactly the same vnodes. Changes are small and we decided that it is OK on the ML sync.

vmarkovtsev commented 5 years ago

@zurk CI still failing

zurk commented 5 years ago

Fixed. Someday we should use FomatAnalyzer in noisy report directly...

vmarkovtsev commented 5 years ago

Yes! Finally.