search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Deploy both format and typos to staging #710

Closed meyskens closed 5 years ago

meyskens commented 5 years ago

This PR makes sure both analyzers run individually inside staging

meyskens commented 5 years ago

@vmarkovtsev thanks! will await working further on this till that is added

vmarkovtsev commented 5 years ago

OK, @irinakhismatullina has added the missing feature, so it should work without including the asdf file now.

meyskens commented 5 years ago

@vmarkovtsev @irinakhismatullina do we need any configuration for the analyzer in lookout now (--config-json='{"lookout.style.typos":{"/src-d/style-analyzer/corrector.asdf"}}') still? Or is there a default model now?

vmarkovtsev commented 5 years ago

@meyskens There is a default model now indeed, so no.

zurk commented 5 years ago

@meyskens I think it is worth to mention that now we use JS driver v2.7.1 (not v.1.2.0 as before) for style Analyzer and Typos Analyzer required all possible drivers. @vmarkovtsev do you think we should pin versions for the rest drivers now?

meyskens commented 5 years ago

@zurk addressed in https://github.com/src-d/lookout/pull/619

meyskens commented 5 years ago

This request is now ready for review! Once ready to deploy a new tagged version is needed to be pushed.

vmarkovtsev commented 5 years ago

OK, we are very close to the initial typos release, so pushing the tag very soon. Thanks!