search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Add reporter for typos analyzer #721

Closed zurk closed 5 years ago

zurk commented 5 years ago

There are two main additions:

  1. An abstraction layer for all Analyzer Reporters. Class that called Reporter
  2. TypoCommitsReporter reported for the commit with typos dataset.

Note, that Reporter takes fix information dirrectly from lookout-sdk which is more straightforward then before.

zurk commented 5 years ago

@vmarkovtsev Addressed. For now, I do not rebase to make review easier. If you want to see new changes: https://github.com/src-d/style-analyzer/compare/81036bf305d3d3ce006919e5e777dcdc9b7952fd..c74e8de74435b85791bdaa339e47d68c74bbdd8e Note that we should merge https://github.com/src-d/style-analyzer/pull/729 before this PR to make it work.

zurk commented 5 years ago

I saw some strange Python 3.5 test failure that was solved by restarting the test. :thinking:

zurk commented 5 years ago

I decided to not include anything new into this PR to make it faster to be merged. In the upcoming PR: report template and tests.

I rebase here and address feedback.

zurk commented 5 years ago

@vmarkovtsev ping