src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Polish IdTyposAnalyzer #729

Closed zurk closed 5 years ago

zurk commented 5 years ago

Minor changes to simplify work with an upcoming reporter.

  1. The biggest limitation I am addressing is that TypoFix instance should be easily converted to a JSON object. So I exclude UAST from it.
  2. Use @with_changed_uasts_and_contents(unicode=True)
  3. Convert pred_probs[i] to float because it has np.float type which fails be converted to a JSON.
  4. Remove candidates to token_candidates to be more specific.
zurk commented 5 years ago

addressed and rebased.

vmarkovtsev commented 5 years ago

@zurk Please merge yourself if CI passes