search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Remove logging args from args given to handlers #730

Closed m09 closed 5 years ago

m09 commented 5 years ago

ok. Then there must be some problem in setup.py because my version was not updated even though I ran pip install .

m09 commented 5 years ago

they don't seem removed: https://github.com/src-d/lookout-sdk-ml/blob/master/lookout/__main__.py#L7

neither in https://github.com/src-d/lookout-sdk-ml/blob/master/lookout/core/cmdline.py#L113

vmarkovtsev commented 5 years ago

I am talking about https://github.com/src-d/modelforge/blob/master/modelforge/slogging.py#L251

vmarkovtsev commented 5 years ago

@m09 I bet that Modelforge is not updated on your side because of the version conflict with sourced-ml. This is why we had to hack the CI, and also opened https://github.com/src-d/ml/issues/396

m09 commented 5 years ago

yup ok, let's close then