search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Update gensim.fasttext usage #754

Open irinakhismatullina opened 5 years ago

irinakhismatullina commented 5 years ago

New release of gensim==3.7.2 broke several things in CandidateGenerator in typos:

  1. Loading fasttext model from the file - easy fix.
  2. Modelforge save/load functions are now broken because of the changed attributes in FasttextKeyedVectors class - not nice, need to rewrite the _generate_tree/_load_tree, but doable.
  3. Because of (2) new models for usage and testing should be trained, and that's the worst of all (reports inconsistencies and so on).

So due to (3) it's suggested to leave it for the future releases, when the new models will be integrated anyway.

zurk commented 5 years ago

@irinakhismatullina I think this one was done, wasn't it?

irinakhismatullina commented 5 years ago

Nope, we just put upper boundary on the gensim version.