search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Fix cloner tests #766

Closed zurk closed 5 years ago

zurk commented 5 years ago

This commit address the recent changes in modelforge (https://github.com/src-d/modelforge/commit/9e10ff214ad356d4073ebadd6374df961ee88975)

The test expected to get each log entry at one line, but it is not the case now.

@vmarkovtsev actually, I am not sure that it is a good idea to have JSON logs formatted with new lines. JSON logs are for processing by design and not for humans. In other words, I think it is better to revert commit in modelforge rather than apply this fix.

vmarkovtsev commented 5 years ago

Oh f*ck this is my fault, I missed that @glimow has changed slogging additionally to the required edits. Yes, we need to remove the slogging indentation ofc.

zurk commented 5 years ago

https://github.com/src-d/modelforge/pull/98