search

src-d / style-analyzer

Lookout Style Analyzer: fixing code formatting and typos during code reviews
GNU Affero General Public License v3.0
32 stars 21 forks source link

Make typos analyzer actually work out-of-the-box #779

Open irinakhismatullina opened 5 years ago

irinakhismatullina commented 5 years ago

Right now due to some problems with dependencies and/or dockerfiles typos analyzer doesn't work out-of-the-box. We need to solve them and finally demo the analyzer.

vmarkovtsev commented 5 years ago

@irinakhismatullina We also need to adjust our CI to actually check that things work out of the box.

irinakhismatullina commented 5 years ago

Agree.

zurk commented 5 years ago

So, this issue should be solved several days before the next demo.

irinakhismatullina commented 5 years ago

cc @vmarkovtsev Right now the command analyzer package lookout.style.typos -y -u github-user -t token -r github-user/repo -w /tmp/pkg fails for me with 

  Building wheel for python-snappy (setup.py): started
  Building wheel for python-snappy (setup.py): finished with status 'error'
  ERROR: Complete output from command /usr/bin/python3 -u -c 'import setuptools, tokenize;__file__='"'"'/tmp/pip-install-ocr9wbyu/python-snappy/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-dpolhloh --python-tag cp36:
  ERROR: /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'cffi_modules'
    warnings.warn(msg)
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib.linux-x86_64-3.6
  creating build/lib.linux-x86_64-3.6/snappy
  copying snappy/__main__.py -> build/lib.linux-x86_64-3.6/snappy
  copying snappy/snappy_cffi_builder.py -> build/lib.linux-x86_64-3.6/snappy
  copying snappy/hadoop_snappy.py -> build/lib.linux-x86_64-3.6/snappy
  copying snappy/snappy.py -> build/lib.linux-x86_64-3.6/snappy
  copying snappy/__init__.py -> build/lib.linux-x86_64-3.6/snappy
  copying snappy/snappy_cffi.py -> build/lib.linux-x86_64-3.6/snappy
  copying snappy/snappy_formats.py -> build/lib.linux-x86_64-3.6/snappy
  running build_ext
  building 'snappy._snappy' extension
  creating build/temp.linux-x86_64-3.6
  creating build/temp.linux-x86_64-3.6/snappy
  x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.6m -c snappy/snappymodule.cc -o build/temp.linux-x86_64-3.6/snappy/snappymodule.o
  snappy/snappymodule.cc:31:10: fatal error: snappy-c.h: No such file or directory
   #include <snappy-c.h>
            ^~~~~~~~~~~~
  compilation terminated.
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for python-snappy
  Running setup.py clean for python-snappy
  Building wheel for thriftpy (setup.py): started
  Building wheel for thriftpy (setup.py): finished with status 'done'
  Stored in directory: /tmp/pip-ephem-wheel-cache-dntwvz0q/wheels/64/ff/0b/00a7ab5df78f8360908e34744eb78c2c537a327a295da5c260
Successfully built PyStemmer python-igraph smart-open tabulate google-compute-engine bz2file sourced-jgit-spark-connector pyspark thriftpy
Failed to build python-snappy
ERROR: lookout-sdk-ml 0.19.1 has requirement modelforge<0.14.0,>=0.13.4, but you'll have modelforge 0.12.1 which is incompatible.
ERROR: sourced-jgit-spark-connector 2.0.1 has requirement bblfsh==2.9.13, but you'll have bblfsh 2.12.7 which is incompatible.
ERROR: sourced-ml 0.8.2 has requirement modelforge<0.12,>=0.11.1, but you'll have modelforge 0.12.1 which is incompatible.
ERROR: lookout-style 0.2.0 has requirement gensim<3.7.2,>=3.7.1, but you'll have gensim 3.8.0 which is incompatible.
Installing collected packages: PyStemmer, blis, boto, jmespath, docutils, botocore, s3transfer, boto3, cymem, bz2file, smart-open, gensim, httplib2, joblib, pytz, pandas, distro, google-compute-engine, python-igraph, tabulate, scikit-learn, scikit-optimize, py4j, pyspark, sourced-jgit-spark-connector, python-snappy, ply, thriftpy, parquet, tqdm, pygments, keras-preprocessing, h5py, keras-applications, keras, modelforge, sourced-ml, xgboost, lookout-style, murmurhash, plac, preshed, sortedcontainers, sourced-ml-core, wasabi, srsly, thinc, spacy, wcwidth
  Found existing installation: httplib2 0.12.3
    Uninstalling httplib2-0.12.3:
      Successfully uninstalled httplib2-0.12.3
  Running setup.py install for python-snappy: started
    Running setup.py install for python-snappy: finished with status 'error'
    ERROR: Complete output from command /usr/bin/python3 -u -c 'import setuptools, tokenize;__file__='"'"'/tmp/pip-install-ocr9wbyu/python-snappy/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-v5r6byte/install-record.txt --single-version-externally-managed --compile:
    ERROR: /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'cffi_modules'
      warnings.warn(msg)
    running install
    running build
    running build_py
    creating build
    creating build/lib.linux-x86_64-3.6
    creating build/lib.linux-x86_64-3.6/snappy
    copying snappy/__main__.py -> build/lib.linux-x86_64-3.6/snappy
    copying snappy/snappy_cffi_builder.py -> build/lib.linux-x86_64-3.6/snappy
    copying snappy/hadoop_snappy.py -> build/lib.linux-x86_64-3.6/snappy
    copying snappy/snappy.py -> build/lib.linux-x86_64-3.6/snappy
    copying snappy/__init__.py -> build/lib.linux-x86_64-3.6/snappy
    copying snappy/snappy_cffi.py -> build/lib.linux-x86_64-3.6/snappy
    copying snappy/snappy_formats.py -> build/lib.linux-x86_64-3.6/snappy
    running build_ext
    building 'snappy._snappy' extension
    creating build/temp.linux-x86_64-3.6
    creating build/temp.linux-x86_64-3.6/snappy
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.6m -c snappy/snappymodule.cc -o build/temp.linux-x86_64-3.6/snappy/snappymodule.o
    snappy/snappymodule.cc:31:10: fatal error: snappy-c.h: No such file or directory
     #include <snappy-c.h>
              ^~~~~~~~~~~~
    compilation terminated.
    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
    ----------------------------------------
ERROR: Command "/usr/bin/python3 -u -c 'import setuptools, tokenize;__file__='"'"'/tmp/pip-install-ocr9wbyu/python-snappy/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-v5r6byte/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-install-ocr9wbyu/python-snappy/
WARNING: You are using pip version 19.1.1, however version 19.2.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
The command '/bin/sh -c apt-get update &&     apt-get install -y --no-install-suggests --no-install-recommends       postgresql-client python3-dev gcc g++ libxml2 zlib1g libxml2-dev make zlib1g-dev &&     pip3 install --no-cache-dir -r requirements.txt &&     apt-get remove -y python3-dev gcc g++ libxml2-dev make zlib1g-dev &&     apt-get autoremove -y &&     apt-get clean &&     rm -rf /var/lib/apt/lists/*' returned a non-zero code: 1

Also there's a ton of inconsistencies with the modelforge version.