search

src-d / talks

Awesome conference website in 5 minutes.
http://talks.sourced.tech
MIT License
0 stars 9 forks source link

Google maps API calls not working in staging environment #78

Open smeruelo opened 7 years ago

smeruelo commented 7 years ago

At the bottom of every talks page, a location map should be shown but it fails.

Error is maps.googleapis.com/maps-api-v3/api/js/30/7/util.js:228 Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys UB.j @ maps.googleapis.com/maps-api-v3/api/js/30/7/util.js:228

Curiously enough, in production environment, it says the same but as a warning, not an error.

@dpordomingo has found out here that

The new policies will apply immediately to all Maps API implementations created on or after June 22nd, 2016. Existing applications have been grandfathered based on their current usage to ensure that they continue to function both now and in the future. We will also be proactively contacting all existing API key users who, based on usage growth patterns, may be impacted in the future.

dpordomingo commented 7 years ago

I think that it would be needed an api key for staging (and having another one for prod would be great). In any case, I can not generate them.

rporres commented 7 years ago

@dpordomingo Can we pass the api key as part of the build process?

dpordomingo commented 7 years ago

There is no API key currently, so it would be needed to add it to the Talks app. Being passed during the build process seems to be necessary, but I have no specs about it yet.