search

src-d / terraform-provider-online

Terraform provider for Online.net
Mozilla Public License 2.0
19 stars 13 forks source link

Add reverse hostname to online_failover_ip #34

Open meyskens opened 6 years ago

meyskens commented 6 years ago

We should add the ability to change the reverse hostname of a failover ip in the online_failover_ip resource instead of a separate one

nclandrei commented 6 years ago

Hi @meyskens! Can I work on this one? šŸ™‚

meyskens commented 6 years ago

@nclandrei sure! If you need any help feel free to ping me for questions

meyskens commented 5 years ago

@nclandrei still working on that one?

nclandrei commented 5 years ago

Hi @meyskens! I really do apologize for being so unresponsive but I had some urgent personal matters and had to fly back home for a while. Is it ok if I finish this today or tomorrow max? šŸ™‚ Again, sorry for not communicating that I left.

nclandrei commented 5 years ago

@meyskens - so if I understand this correctly, the changes should be something similar to the ones described in #10 (the implementation for this task should be similar as what was done for the reverse hostname for the server)? I had a look through the code to understand it properly and was just wondering if Iā€™m on the right track šŸ˜

meyskens commented 5 years ago

That's correct, in #10 the idea was to make a reverse_hostname resource while here the idea is to have like

resource "online_failover_ip" "test" {
  ip = "127.0.0.1"
  hostname = "localhost.sourced.tech"
}