search

src-d / terraform-provider-online

Terraform provider for Online.net
Mozilla Public License 2.0
19 stars 13 forks source link

detect missing online token #35

Closed denwwer closed 6 years ago

denwwer commented 6 years ago

33 Used nil as default ONLINE_TOKEN value, added testing.

rporres commented 6 years ago

Thanks a lot for your contribution

Your approach is a bit problematic as it will force to add that code in every resource test. Another problem is that missing token test should not be part of any resource test.

Solution to this issue should be part of provider_test.go to avoid code repetition.

denwwer commented 6 years ago

test changed

rporres commented 6 years ago

This looks great. We've just merged a couple of big PRs. Can you rebase from master and retest to make sure things are ok all over the place? Thanks!

denwwer commented 6 years ago

ok