search

srcbookdev / srcbook

TypeScript-centric app development platform
https://srcbook.com
Apache License 2.0
2.6k stars 101 forks source link

Add create file and folder within another folder #356

Closed benjreinhart closed 1 month ago

benjreinhart commented 1 month ago

Unfortunately this is a bit buggy. Getting the focus states working smoothly is not an easy task.

nichochar commented 1 month ago

Damn the logic is really finicky. Wonder if there are some product simplifications we can do.

benjreinhart commented 1 month ago

I definitely agree it's finicky, but it's only the focus portion that's finicky which is currently self contained in a component that's only about 20-30 lines of code, so I'm not terribly concerned at the moment. While I think we could shift around the UX to avoid this problem (e.g., in the extreme case you could use pop up a modal to create a new file), I think this is the UX people are used to for editing experiences.

benjreinhart commented 1 month ago

I think we can just live with this for a bit and revisit before launching.