srcbookdev / srcbook

TypeScript-centric app development platform
https://srcbook.com
Apache License 2.0
2.58k stars 101 forks source link

Make WebSocket subscriptions receive ack to be considered subscribed #409

Closed benjreinhart closed 1 month ago

benjreinhart commented 1 month ago

This allows us to implement logic where we only send events once the server has confirmed our subscription. This ensures that the server will not try to broadcast something before we're subscribed, leading to events that never make it to the client.

This probably mostly only happens in dev because of the mounting/unmounting/remounting resulting in useEffect running multiple times initially. There's a small window where events can get dropped in that. In a production build, it's more unlikely we'd have issues here, but this is good in either case as subscriptions really should be acknowledged by the server before we start sending events.