bug: when nosteam spoofer gets disconnected, incoming steam player gets steam_id_pending

[maxime1907]

Its due to ->Disconnect not being executed directly but rather on next frames so i guess it does EndAuthSession before legit client gets time to connect:

• https://github.com/srcdslab/sm-ext-connect/blob/0bda1e1f898b504745d12decea4dbf59ec5fc8a8/extension.cpp#L452

[maxime1907]

L 09/14/2023 - 00:49:42: [CONNECT] STEAM_0:0:8519363 ExistingStorageStored: 0, SteamAuthFailed: 1 (1), Async: 0
L 09/14/2023 - 00:49:42: [CONNECT] STEAM_0:0:8519363 SteamAuthFailed: 1 (1) | retVal = 1
L 09/14/2023 - 00:49:42: [CONNECT] player_connect(user_id=24, networkid=[U:1:17038726], bot=0)
L 09/14/2023 - 00:49:42: [CONNECT] STEAM_0:0:8519363 OnClientConnecting
Client "rabi" connected ().
L 09/14/2023 - 00:49:42: [CONNECT] STEAM_0:0:8519363 SteamLegal: 0 (0)
L 09/14/2023 - 00:49:42: [CONNECT] player_disconnect(user_id=24, networkid=[U:1:17038726], bot=0)
L 09/14/2023 - 00:49:42: [CONNECT] STEAM_0:0:8519363 OnClientDisconnecting
Dropped rabi from server (STEAM UserID [U:1:17038726] is already
in use on this server)
L 09/14/2023 - 00:49:42: [CONNECT] STEAM_ID_STOP_IGNORING_RETVALS SteamClientAuthenticated: FALSE!
L 09/14/2023 - 00:49:42: [custom/PlayerManager.smx] Potential spoofer Boss STEAM_ID_STOP_IGNORING_RETVALS

Spoofer gets disconnected after legit player gets connected so it removes the existing storage

Links

• https://github.com/srcdslab/source-engine-2018-hl2_src/blob/0301dccccd5553587cba988daa0763081a1f409e/engine/baseclient.cpp#L604

Solution

• Fixed storage problem by disconnecting player
• Send a retry to the client if he has steam id pending with a valid steam authentication

[maxime1907]

Procedure to reproduce the bug

Connect to the server and wait to be fully ingame Unplug your internet cable Disconnect from the server Plug back your internet cable Connect to the server and you will get steam_id_pending