Feat: Plugin cleanup - Githubissues

notkoen commented 2 months ago

The goal of this pull request is to clean up the plugin and remove unnecessary or unused features. Because CS:GO is now considered legacy and no longer has many active servers, CSGO support was dropped. I am open to discussing and working on the changes.

Changes in this pull request:

Fixed inconsistent code formatting and removed trailing whitespace
Removed CSGO engine check
Remove player_hurt event and all related code
Reworked settings cookie menu so players can toggle settings directly in the SM cookie menu
Updated cookie code to use dedicated method maps such as .Get and .Set
Removed unused functions
Removed HP bar display that used emoji/symbols

notkoen commented 2 months ago

CC @maxime1907 @Rushaway

Rushaway commented 2 months ago

#L903: Instead of performing this here, better to perform this on OnAllPluginsLoaded, OnLibraryAdded, OnLibraryRemoved It will reduce the numbers of calls. Like here

Rushaway commented 2 months ago

We can also maybe use GetExtensionFileStatus to know if the native for SDKHook_OnEntitySpawned is available and set the result as a bool. It will reduce the numbers of calls aswell since OnEntityCreated and OnEntityDestroyed are super expensive

srcdslab / sm-plugin-BossHUD

Feat: Plugin cleanup #25