search

srcery-colors / srcery-vim

Srcery is a dark color scheme with clearly defined contrasting colors and a slightly earthy tone.
https://srcery.sh
Other
824 stars 60 forks source link

Neovim 0.10.0 Update Breaks Highlight Groups #119

Open GophUndMe opened 4 months ago

GophUndMe commented 4 months ago

With the new update to Neovim, 0.10.0, some changes to highlighting groups have caused colors to switch roles, some to turn completely white, etc.

I've personally seen this while using Golang highlighting, both with and without Treesitter.

The related patch notes can be found here:

https://neovim.io/doc/user/news-0.10.html

These Nvim specific highlight groups are now defined in a meaningfully different way and might need an update:
[hl-FloatBorder](https://neovim.io/doc/user/syntax.html#hl-FloatBorder) is linked to [hl-NormalFloat](https://neovim.io/doc/user/syntax.html#hl-NormalFloat) instead of [hl-WinSeparator](https://neovim.io/doc/user/syntax.html#hl-WinSeparator).
[hl-NormalFloat](https://neovim.io/doc/user/syntax.html#hl-NormalFloat) is not linked to [hl-Pmenu](https://neovim.io/doc/user/syntax.html#hl-Pmenu).
[hl-WinBar](https://neovim.io/doc/user/syntax.html#hl-WinBar) has different background.
[hl-WinBarNC](https://neovim.io/doc/user/syntax.html#hl-WinBarNC) is similar to [hl-WinBar](https://neovim.io/doc/user/syntax.html#hl-WinBar) but not bold.
[hl-WinSeparator](https://neovim.io/doc/user/syntax.html#hl-WinSeparator) is linked to [hl-Normal](https://neovim.io/doc/user/syntax.html#hl-Normal) instead of [hl-VertSplit](https://neovim.io/doc/user/deprecated.html#hl-VertSplit).
This also might result into some color schemes looking differently due to them relying on implicit assumptions about how highlight groups are defined by default. To account for this, define all attributes of highlight groups explicitly. Alternatively, use :colorscheme vim or :source $VIMRUNTIME/colors/vim.lua to restore previous definitions.

There's a work-around listed, but it doesn't seem to have any effect for me. A fixing update would be appreciated!

roosta commented 4 months ago

Hi, thanks for reporting. Could you be a bit more specific about the issues you're experiencing? There's an issue with golang? any other languages you've had issues with? The changenotes for neovim doesn't indicate it should mess with highlight groups.

roosta commented 4 months ago

Anyone who can shed some more light on this? I don't have the issues reported, but there are other colorschemes having the same issue

They mention a workaround for legacy schemes, but I need to be able to reproduce somehow