Underline does not work, works fine with other colorschemes

srcery-colors / srcery-vim

Srcery is a dark color scheme with clearly defined contrasting colors and a slightly earthy tone.

https://srcery.sh

Other

829 stars 60 forks source link

Underline does not work, works fine with other colorschemes #85

Closed ixolius closed 1 year ago

ixolius commented 2 years ago

Expected behaviour

When using a colorscheme such as solarized, my coc.nvim-plugin underlines language errors correctly grafik

Actual behaviour

Srcery fails to display the underline. grafik

What I tried

I played around with g:srcery_hard_black_terminal_bg, g:srcery_underline and g:srcery_undercurl. For the moment, I use g:srcery_guisp_fallback but this is not a "real" workaround.

System details

I use konsole as terminal emulator. I use vim 8.2.5172.

Offer to help

If you need it, I can provide several versions of a .vimrc that may reproduce this behaviour. If needed, I can also try to compare this sourcecode with the sourcecode of the solarized project to see what is wrong.

roosta commented 2 years ago

Hi! Thanks for letting us know. I think this is because it isn't underline coc.nvim uses in srcery, its undercurl, and I suppose that doesn't work correctly in konsole.

ixolius commented 1 year ago

Hi @roosta , thanks for the response. I took the time and tried gnome-terminal. This is srcery: grafik And this is a solarized colorscheme: grafik

I don't think my issue has anything to do with konsole (Maybe suggest me a terminal emulator that should work). So what is the problem here? If this is a problem of the terminal emulator or coc.nvim, then why does the solarized palette work? I feel like I don't understand something. Can someone explain with a little more detail what is happening here?

roosta commented 1 year ago

Undercurl isn't supported by all terminal emulators, one I know it does work is alacritty I use that one myself. The reason I didn't provide any more details is that it varies from terminal to terminal, and often if you run a multiplexer (screen,tmux) usually complicates things further. Its a config issue, not a theme issue, and I can really only vouch for alacritty.

I am able to fall back to underline when using konsole myself, using stock config and srcery theme.

roosta commented 1 year ago

Do you get underline/undercurl without coc.nvim?

ixolius commented 1 year ago

Thanks for the details. I will test different things over the weekend, you could help me by answering the following questions

Which version of konsole and vim do you use? (it's 19.12.3 and 8.2 for me)?
Can you pass me your konsole configuration?
Can you tell me how to test underline/undercurl without coc.nvim? I have no idea how to cause underlines...

roosta commented 1 year ago

konsole version 22.08.3
I didn't use any config, I just installed it and opened vim. There is some cruft in my config folder but it all is auto generated.
To test if underline and undercurl works without coc.nvim, type :highlight, and scroll until you see examples of both

roosta commented 1 year ago

Closing due to inactivity