search

srcery-colors / srcery-vim

Srcery is a dark color scheme with clearly defined contrasting colors and a slightly earthy tone.
https://srcery.sh
Other
809 stars 60 forks source link

ci: run lint job on pull requests #86

Closed MindTooth closed 1 year ago

MindTooth commented 1 year ago

Should now be able to track incoming changes for any errors.

Stole it from here: https://docs.github.com/en/actions/using-workflows/creating-starter-workflows-for-your-organization

MindTooth commented 1 year ago

Hmm. This did not in fact trigger a pipeline. 🤔 No constraint on file types, so it should have.

roosta commented 1 year ago

Oh, it didn't trigger. Hmm

MindTooth commented 1 year ago

Works now. But, thoughts on switching to https://github.com/reviewdog/action-vint instead?

roosta commented 1 year ago

Yeah, much preferable I think, didn't know there was an action for that

MindTooth commented 1 year ago

Hmm. It works, but the pipeline succeeded with an error posted? Perhaps that must happen for this to work. 🤔

Ed1t: Guess this works best with requiring all conversations resolved.

roosta commented 1 year ago

Hmm, I also expected it to fail, but I suppose this will work just as well, if not better.

roosta commented 1 year ago

https://github.com/reviewdog/action-vint/issues/6

MindTooth commented 1 year ago

Tried failure, ref.: https://github.com/reviewdog/reviewdog#exit-codes

But does not work. 🤔

Think perhaps I've read this wrong.

roosta commented 1 year ago

try setting it to error

(optional. same as -level flag. [info,warning,error])

MindTooth commented 1 year ago

I think error is the default. My suspicion is that this action does not take into account the exist code.

MindTooth commented 1 year ago

Personally I'm fine with having the old setup, but just making sure pull requests are included. Thoughts?

roosta commented 1 year ago

Agreed, seems it the action doesn't work quite like we expected. If you can get the old one on prs that'd be perfect.