srcfl / srcful-gateway

Srcful energy gateway to connect your solar inverter and mine src-token
https://srcful.io
MIT License
5 stars 2 forks source link

Scan should return a list devices found #214

Open davmoz opened 1 month ago

davmoz commented 1 month ago

The scan for inverters function should be improved to return a list of devices and their MAC addresses. This way, if a device gets a new IP address through DHCP, we can still identify it using its MAC address. This will help us avoid mixing up proxies with actual inverters.

davmoz commented 1 month ago

Containers using bridge networking cannot directly obtain the MAC addresses of external devices due to network isolation and lack of Layer 2 visibility. This limitation prevents standard tools or scripts within the container from accessing MAC address information. Let's consider isolating this functionality by breaking it out into its own container/service and provide information such as device ip, device mac, and arp table from there.

Perhaps we should just rename Bluetooth and let it do this work since it is already using the host network and has escalated privileges?

Regardless, I'm moving this to the next iteration as it might need quite some testing post-release.