search

sre-summercamp / sre-summercamp.github.io

SRE SummerCamp 2022 website
https://sre-summercamp.github.io
0 stars 0 forks source link

light theme: red background is pretty? #21

Closed tormath1 closed 2 years ago

tormath1 commented 2 years ago

photo_2022-08-01_12-47-10

Even from a private navigation windows

tormath1 commented 2 years ago

from a quick look --primary color is missing.

tormath1 commented 2 years ago

aaah ok, it's not a bug - it's just based on the prefers-color-scheme: dark|light. https://github.com/sre-summercamp/devfest-theme-hugo/blob/c9752a475ccd03619b5838bcde5974017eb818ff/src/styles/_root.scss#L114

@pabluk what do you think having the blue theme by default? The red is a bit hurting.

pabluk commented 2 years ago

@pabluk what do you think having the blue theme by default? The red is a bit hurting.

Yes, no problem, I have no advice on colors, I'm very bad on design.

https://github.com/sre-summercamp/devfest-theme-hugo/blob/c9752a475ccd03619b5838bcde5974017eb818ff/src/styles/_root.scss#L114

Exactly, if you wanna try other colors schema you just need to edit that line and this one https://github.com/sre-summercamp/devfest-theme-hugo/blob/c9752a475ccd03619b5838bcde5974017eb818ff/src/styles/_root.scss#L2

tormath1 commented 2 years ago

I'm very bad on design.

We're two then.

I feel that the blue one fits better with the water color: tmp 0KQ64kh3ZF

pabluk commented 2 years ago

I feel that the blue one fits better with the water color:

Totally right! looks better with the sky and water :+1: Go for it!

pabluk commented 2 years ago

@tormath1 I think in this commit https://github.com/sre-summercamp/sre-summercamp.github.io/commit/85ae1f82a3128333080a33687f9bc32b532f6ed8 you also need to commit the generated file static/theme.css from the https://github.com/sre-summercamp/devfest-theme-hugo repo.