srednak / balena-st-stm32mp

Balena support for stm32mp boards
Apache License 2.0
1 stars 3 forks source link

balenaOS fork - necessary changes #1

Open acostach opened 2 years ago

acostach commented 2 years ago

Hi @srednak and thank you for work on supporting balenaOS on this board!

I have forked your repository at https://github.com/balena-os/balena-st-stm32mp and will need a couple more things to bring this device type to the cloud:

1) We'll need an svg icon and a contract which uses the same 'slug' as the device, for example https://github.com/balena-io/contracts/tree/master/contracts/hw.device-type/nanopc-t4 2) The slug will need to be set here: https://github.com/srednak/balena-st-stm32mp/blob/dunfell/qsmp1570-qsbase1.coffee#L6 , and should be the same as in the contracts. I suggest using the 'qsmp1570-qsbase1' slug. 3) Provisioning instructions will need to be filled in the coffee file: https://github.com/srednak/balena-st-stm32mp/blob/dunfell/qsmp1570-qsbase1.coffee#L12 I see the README mentions that only eMMC has been tested, so the provisioning instructions will need to mention how the eMMC should be flashed. 4) This directory does not contain yocto recipes and should be removed: https://github.com/srednak/balena-st-stm32mp/tree/dunfell/layers/meta-balena-st-stm32mp 5) This line in the supervisor recipe isn't needed anymore: https://github.com/srednak/balena-st-stm32mp/blob/dunfell/layers/meta-balena-st-stm32mp/recipes-containers/docker-disk/balena-supervisor.bbappend#L1 because it has been renamed here: https://github.com/balena-os/meta-balena/commit/2d284b2015e3d7f6c6a37a63ce49f6f89da7696d 6) Is this append really necessary: https://github.com/srednak/balena-st-stm32mp/blame/dunfell/layers/meta-balena-st-stm32mp/recipes-devtools/kernel-modules-headers/kernel-modules-headers.bbappend ? Can you check if dropping works? 7) Is this file used: https://github.com/srednak/balena-st-stm32mp/tree/dunfell/layers/meta-balena-st-stm32mp/recipes-support/balena-init ? In the coffee file I see the image is not a flasher and also the directory name is 'balena-init', different from the corespondent in meta-balena, so the resin-init-flasher append is not used in the build.

For steps 4 to 7 it would be great if you could also update the repository to the latest revision of balenaOS and balena-yocto-scripts to check if the build succeeds and the device boots fine? Once the above points are addressed we will pull your updated repo in our fork and deploy the image in the dashboard.

Thank you

floion commented 1 year ago

@srednak are you still using this device type?

srednak commented 1 year ago

Personally I don't. It was used on my previous job.

Den ons 31 maj 2023 11:07Florin Sarbu @.***> skrev:

@srednak https://github.com/srednak are you still using this device type?

— Reply to this email directly, view it on GitHub https://github.com/srednak/balena-st-stm32mp/issues/1#issuecomment-1569797698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7GFDR37NU2CBP5SKGPFM3XI4C55ANCNFSM5RQNAUZA . You are receiving this because you were mentioned.Message ID: @.***>

floion commented 1 year ago

Thanks. Can you put us in contact with somebody from your previous company so we can check if they still use this?

pickus-df commented 2 months ago

@floion Hi, I'm working as a project manager responsible for this. We are still using this and are interested in bringing this to balena. You can reach me at mikael.lauren@addiva.se.