finish partinfo to and from dict - Githubissues

sree314 / stepcvt

Generate STL files for 3D printing from STEP files

2 stars 0 forks source link

finish partinfo to and from dict #14

Closed redrn closed 8 months ago

redrn commented 8 months ago

Resolves issue #9.

project.py:

Added a gettype method in TaskInfo class to simplify dict serialization code.
PartInfo constructor was not using its parameter part_id. Not sure if this is a conscious choice or a typo. Fixed it anyway.
Minor bugs.

test_part_info.py:

Expanded test_PartInfo_from_dict to include other TaskInfo class such as SlicerSettingsInfo.
Moved pinfo into global scope, so it can be reused in test_PartInfo_to_dict.
Some TaskInfo serialization do not seem to be working correctly so did not expand test_PartInfo_to_dict to test for those.

sree314 commented 8 months ago

Roy, can you install the pre-commit hook, run black, and resubmit?

pre-commit install
pre-commit run --all-files