search

sree314 / stepcvt

Generate STL files for 3D printing from STEP files
2 stars 0 forks source link

Add more tests for to_dict() in project class & Fix the bug #45

Closed ymh1003 closed 10 months ago

ymh1003 commented 10 months ago

The to_dict() in project class does not have a corresponding test in test_project.py that checks for individual partinfo - sree Fix the functionality of to_dict() and from_dict() in project class - Samantha

sree314 commented 10 months ago

Project to_dict does not recurse into cad source, etc. so it does not return that information.

sree314 commented 10 months ago

@skriegsman , I added the test, please write code to make to_dict() recursive. Please work in this branch

skriegsman commented 10 months ago

I made sure my branch (swkriegsman_a6_addSource) is up to date. I added sources to the to_dict() function but I didnt make it recursive. Either way the pytests doesnt throw an error about it so I am not sure what exactly I am meant to fix

ymh1003 commented 10 months ago

@skriegsman , the newly added test is on branch 45-add-more-tests-for-to_dict-in-project-class-fix-the-bug. Please work in that branch.

skriegsman commented 10 months ago

Merged the test into swk-a6 branch and closed by pull request #52 . Test doesn't pass because of an error in CADSource Class