search

sree314 / stepcvt

Generate STL files for 3D printing from STEP files
2 stars 0 forks source link

fixing failed tests #49

Closed Asai-Yume closed 7 months ago

Asai-Yume commented 7 months ago

I looked at the book step file made in models.py. The part_id should be "book_body", but the test is failing because the method appended a "_part" to "book_body", should the test be changed? Or is it something in model.py that I am missing?

Asai-Yume commented 7 months ago

I looked at the book step file made in models.py. The part_id should be "book_body", but the test is failing because the method appended a "_part" to "book_body", should the test be changed? Or is it something in model.py that I am missing?

If I change the test into expected_partids = set(["book_body_part", "spine_part"]), the test will pass, but I am not sure why the _part string is being appended to the partids.

sree314 commented 7 months ago

I have to say I don't know either. Worth discussing tomorrow.

Asai-Yume commented 7 months ago

I think this can be merged for now, and I will have to ask Roy to fix whatever issue PartInfo is having.