search

sreedevk / deduplicator

Filter, Sort & Delete Duplicate Files Recursively
MIT License
264 stars 15 forks source link

[Bug] Output Printing Slow #30

Closed sreedevk closed 1 year ago

sreedevk commented 1 year ago

Describe the bug After the scanning is complete, the app hangs for a second before printing the output. This is clearer with large directories.

Runtime Info Install Type: [e.g. cargo install] App Version: [e.g. v0.1.1]

Expected behavior Printing should be fast

Platform Details (please complete the following information):

beeb commented 1 year ago

Might be worth investigating if that's due to the sorting by filesize

sreedevk commented 1 year ago

@beeb I don't think so, this issue existed before the sorting too. the sorting may have added a little bit of overhead but I don't think that has drastically affected anything. The problem is with the time taken to build the prettytable-rs table. The possible solutions are Either creating a streaming output or adding another progress bar for "generating output".

sreedevk commented 1 year ago

42 Adds a progress bar while generating large outputs to avoid blank state.